On Mon, May 31, 2010 at 02:01:22PM +0200, Dan Carpenter wrote:
> This patch moves the dereference after the check for NULL.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 5de80a1..b99db09 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -355,10 +355,11 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> {
> struct tps6507x_dev *tps6507x_dev = platform_get_drvdata(pdev);
> struct tps6507x_ts *tsc = tps6507x_dev->ts;
> - struct input_dev *input_dev = tsc->input_dev;
> + struct input_dev *input_dev;
>
> if (!tsc)
> return 0;
> + input_dev = tsc->input_dev;
>
Why would tsc ever be NULL?
Also I really do not like that pdev's driver data that is supposed to be
driver-private data is being used by the parent. Parent should be using
it's own drvdata and leave child's data alone. We should probably do in
platform code what I2C is about to do and clear drvdata on unbind
automatically to prevent this kind of misuse.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
