From: Sjur Brændeland <sjurbren@xxxxxxxxx> Date: Mon, 24 May 2010 22:47:41 +0200 > Dan Carpenter <error27@xxxxxxxxx> wrote: >> "phyinfo" can never be null here because we assigned it an address, so I >> removed both the assert and the second check inside the if statement. I >> removed the "phyinfo->phy_layer != NULL" check as well because that was >> asserted earlier. >> >> Walter Harms suggested I move the "phyinfo->phy_ref_count++;" outside >> the if condition for readability, so I have done that. >> >> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > Acked-by: Sjur Braendeland <sjur.brandeland@xxxxxxxxxxxxxx> > Thanks, this looks good. Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html