Hi Dan, Qiang brother have a busy doing business, so I can maintain the nuc900fb driver instead. It looks good to me. Andrew , Could you help merge this patch? thanks a lot! Acked-by: Wan ZongShun<mcuos.com@xxxxxxxxx> 2010/5/20 Dan Carpenter <error27@xxxxxxxxx>: > Ping. Any feedback on this patch? > > regards, > dan carpenter > > On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote: >> We should be releasing "res->start" here. >> >> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> >> --- >> BTW. Congratulations on being an official driver maintainer now. :) Can >> you add yourself to the MAINTAINERS file? >> >> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c >> index 6bf0d46..d4cde79 100644 >> --- a/drivers/video/nuc900fb.c >> +++ b/drivers/video/nuc900fb.c >> @@ -667,7 +667,7 @@ release_irq: >> release_regs: >> iounmap(fbi->io); >> release_mem_region: >> - release_mem_region((unsigned long)fbi->mem, size); >> + release_mem_region(res->start, size); >> free_fb: >> framebuffer_release(fbinfo); >> return ret; > -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900@xxxxxxxxxxxxxxxx main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
