Ping. Any feedback on this patch? regards, dan carpenter On Thu, Mar 25, 2010 at 01:54:08PM +0300, Dan Carpenter wrote: > We should be releasing "res->start" here. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > --- > BTW. Congratulations on being an official driver maintainer now. :) Can > you add yourself to the MAINTAINERS file? > > diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c > index 6bf0d46..d4cde79 100644 > --- a/drivers/video/nuc900fb.c > +++ b/drivers/video/nuc900fb.c > @@ -667,7 +667,7 @@ release_irq: > release_regs: > iounmap(fbi->io); > release_mem_region: > - release_mem_region((unsigned long)fbi->mem, size); > + release_mem_region(res->start, size); > free_fb: > framebuffer_release(fbinfo); > return ret; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html