>>>>> "Dan" == Dan Carpenter <error27@xxxxxxxxx> writes: Dan, This one bitrotted in my mailbox for a while because it conflicted with something else I was working on and then it slipped through the cracks. Sorry about that. Dan> The difference between "sectors" and "nr_sectors" is that "sectors" Dan> is in terms of 512 byte sectors and "nr_sectors" is in terms of Dan> hardware sectors. They are only different for 4k sector devices. Dan> Also I changed the name because as Jamie Lokier points out, "that Dan> code is so asking for the variable to be called 'hw_sectors'." The change is obviously functionally correct. But I object to the notion of hw_sectors. The 1:1 mapping of DIF tuples and logical blocks is even going away in SBC3. So let's not perpetuate that. I have a patch in my queue that gets rid of all the hw_sector references in the integrity code. I'll make sure to include your fix. So thanks for spotting this. I obviously haven't tested PI drives with a 4KB logical block size in combination with device mapper... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
