Smatch tagged this code as suspicious because we never use the "nr_sectors" variable. Looking at the code, I think we did intend to use "nr_sectors" instead of "sectors" when we call bio_integrity_mark_tail(). The difference between "sectors" and "nr_sectors" is that "sectors" is in terms of 512 byte sectors and "nr_sectors" is in terms of hardware sectors. They are only different for 4k sector devices. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> --- I'm only guessing as to the intent and I can't test this myself. Please handle with care. diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c index 612a5c3..ce65453 100644 --- a/fs/bio-integrity.c +++ b/fs/bio-integrity.c @@ -676,7 +676,7 @@ void bio_integrity_trim(struct bio *bio, unsigned int offset, nr_sectors = bio_integrity_hw_sectors(bi, sectors); bip->bip_sector = bip->bip_sector + offset; bio_integrity_mark_head(bip, offset * bi->tuple_size); - bio_integrity_mark_tail(bip, sectors * bi->tuple_size); + bio_integrity_mark_tail(bip, nr_sectors * bi->tuple_size); } EXPORT_SYMBOL(bio_integrity_trim); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
