On Mon, Mar 22, 2010 at 06:28:45PM +0300, Dan Carpenter wrote: > I was concerned about the error handling for crypto_get_attr_type() in > pcrypt_alloc_aead(). Steffen Klassert pointed out that we could simply > avoid calling crypto_get_attr_type() if we passed the type and mask as a > parameters. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Steffen Klassert <steffen.klassert@xxxxxxxxxxx> Thanks a lot! > --- > All three versions have basically been the same except for style issues. > I will confess that this (hopefully final :P) version looks much nicer > than the earlier ones. > It's not only style issues. We also got some additional benefit from this version. We got rid of a superfluous call to crypto_get_attr_type and we are able to change type and mask before we pass it to pcrypt_alloc_aead if this becomes necessary. Steffen -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
