On Sun, Mar 21, 2010 at 12:28:47PM +0300, Dan Carpenter wrote: > crypto_get_attr_type() can returns ERR_PTRs if there is a problem. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c > index 8020124..41bd80f 100644 > --- a/crypto/pcrypt.c > +++ b/crypto/pcrypt.c > @@ -322,6 +322,8 @@ static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb) > struct crypto_attr_type *algt; > > algt = crypto_get_attr_type(tb); > + if (IS_ERR(algt)) > + return ERR_CAST(algt); > > alg = crypto_get_attr_alg(tb, algt->type, > (algt->mask & CRYPTO_ALG_TYPE_MASK)); I've just noticed that we are calling crypto_get_attr_type already in pcrypt_alloc, so perhaps we could just pass the type and mask to pcrypt_alloc_aead. Then we can remove this second call to crypto_get_attr_type completely. Steffen -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
