On Sat, 2010-03-20 at 17:39 +0300, Dan Carpenter wrote: > The original code doesn't work because "call" is never NULL there. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Thanks, I'll apply and test this on Monday. -- Steve > > --- > The original patch was fine, but this version is more tasteful. ;) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 4615f62..c1a263a 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -1397,7 +1397,7 @@ int ftrace_profile_set_filter(struct perf_event *event, int event_id, > } > > err = -EINVAL; > - if (!call) > + if (&call->list == &ftrace_events) > goto out_unlock; > > err = -EEXIST; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
