From: Vlad Yasevich <vladislav.yasevich@xxxxxx> Date: Wed, 20 Jan 2010 13:10:10 -0500 > > > Julia Lawall wrote: >> From: Julia Lawall <julia@xxxxxxx> >> >> The variable newinet is initialized twice to the same (side effect-free) >> expression. Drop one initialization. >> >> A simplified version of the semantic match that finds this problem is: >> (http://coccinelle.lip6.fr/) >> >> // <smpl> >> @forall@ >> idexpression *x; >> identifier f!=ERR_PTR; >> @@ >> >> x = f(...) >> ... when != x >> ( >> x = f(...,<+...x...+>,...) >> | >> * x = f(...) >> ) >> // </smpl> >> >> Signed-off-by: Julia Lawall <julia@xxxxxxx> > > Acked-by: Vlad Yasevich <vladislav.yasevich@xxxxxx> Julia, just like patch #3 this one had the missing final line of the patch corrupting it, so you'll need to resubmit. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
