Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > The variable newinet is initialized twice to the same (side effect-free) > expression. Drop one initialization. > > A simplified version of the semantic match that finds this problem is: > (http://coccinelle.lip6.fr/) > > // <smpl> > @forall@ > idexpression *x; > identifier f!=ERR_PTR; > @@ > > x = f(...) > ... when != x > ( > x = f(...,<+...x...+>,...) > | > * x = f(...) > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Acked-by: Vlad Yasevich <vladislav.yasevich@xxxxxx> > > --- > net/sctp/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/socket.c b/net/sctp/socket.c > index 67fdac9..f6d1e59 100644 > --- a/net/sctp/socket.c > +++ b/net/sctp/socket.c > @@ -6359,7 +6359,7 @@ void sctp_copy_sock(struct sock *newsk, struct sock *sk, > struct sctp_association *asoc) > { > struct inet_sock *inet = inet_sk(sk); > - struct inet_sock *newinet = inet_sk(newsk); > + struct inet_sock *newinet; > > newsk->sk_type = sk->sk_type; > newsk->sk_bound_dev_if = sk->sk_bound_dev_if; > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
