On Sunday, December 27, 2009 3:08 PM, Julia Lawall wrote: >>> dbgfs_chan = kmalloc(sizeof(*dbgfs_state) * num_dma_channels, >>> GFP_KERNEL); >>> - if (!dbgfs_state) >>> + if (!dbgfs_chan) >>> goto err_alloc; >> Shouldn't the malloc line read: >> >> ... = kmalloc(sizeof(*dbgfs_chan) * ...) >> ^^^^^^^^^^ >> >> ? > > Good point, thanks. I will send a revised patch. Wouldn't this be clearer? ... = kmalloc(sizeof(struct dentry) * ...) Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
