On Sun, 27 Dec 2009, Uwe Kleine-König wrote: > On Sun, Dec 27, 2009 at 10:26:54PM +0100, Julia Lawall wrote: > > From: Julia Lawall <julia@xxxxxxx> > > > > Test the just-allocated value for NULL rather than some other value. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > .... > > // </smpl> > > > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > > > --- > > arch/arm/plat-pxa/dma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff -u -p a/arch/arm/plat-pxa/dma.c b/arch/arm/plat-pxa/dma.c > > --- a/arch/arm/plat-pxa/dma.c > > +++ b/arch/arm/plat-pxa/dma.c > > @@ -244,7 +244,7 @@ static void pxa_dma_init_debugfs(void) > > > > dbgfs_chan = kmalloc(sizeof(*dbgfs_state) * num_dma_channels, > > GFP_KERNEL); > > - if (!dbgfs_state) > > + if (!dbgfs_chan) > > goto err_alloc; > Shouldn't the malloc line read: > > ... = kmalloc(sizeof(*dbgfs_chan) * ...) > ^^^^^^^^^^ > > ? Good point, thanks. I will send a revised patch. julia
