On Sat, 11 Jul 2009, Greg KH wrote: > On Sat, Jul 11, 2009 at 10:17:24AM +0200, Jiri Slaby wrote: > > On 07/11/2009 09:51 AM, Julia Lawall wrote: > > > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c > > > --- a/drivers/staging/otus/wwrap.c > > > +++ b/drivers/staging/otus/wwrap.c > > > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work) > > > { > > > struct usbdrv_private *macp = > > > container_of(work, struct usbdrv_private, kevent); > > > - zdev_t *dev = macp->device; > > > + zdev_t *dev; > > > > > > if (macp == NULL) > > > { > > > return; > > > } > > > > The test is rather useless here. > > Yes it is. > > Julia, if you just remove the NULL check, will that keep your scripts > happy from noticing such a "problem"? Yes. The trigger is the NULL test after the dereference. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html