On Sat, Jul 11, 2009 at 10:32:23AM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Apparently, the NULL test is not necessary at this point. > > The semantic patch that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > type T; > expression E; > identifier i,fld; > statement S; > @@ > > - T i = E->fld; > + T i; > ... when != E > when != i > if (E == NULL) S > + i = E->fld; > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > drivers/staging/otus/wwrap.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c > index 4db8f6e..855ff41 100644 > --- a/drivers/staging/otus/wwrap.c > +++ b/drivers/staging/otus/wwrap.c > @@ -1018,11 +1018,6 @@ void kevent(struct work_struct *work) > container_of(work, struct usbdrv_private, kevent); > zdev_t *dev = macp->device; > > - if (macp == NULL) > - { > - return; > - } > - Ok, that will teach me to read all of my mail before responding... :) This looks good, I'll queue it up, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
