2009/1/23 Richard Genoud <richard.genoud@xxxxxxxxx>:
> 2009/1/23 Daniele Venzano <venza@xxxxxxxxxxxx>:
>> I changed the patch to not define backlight only in case the driver is
>> compiled as module. Now it compiles both statically or as module without
>> errors or warnings.
>>
>> Patch is against 2.6.28.1
>>
>> Signed-off-by: Daniele Venzano <venza@xxxxxxxxxxxx>
>>
>> --- linux-2.6.28.1/drivers/video/aty/aty128fb.c.old 2009-01-20 16:08:06.000000000 +0100
>> +++ linux-2.6.28.1/drivers/video/aty/aty128fb.c 2009-01-23 11:34:16.000000000 +0100
>> @@ -360,8 +360,10 @@ static int mtrr = 1;
>> #ifdef CONFIG_PMAC_BACKLIGHT
>> static int backlight __devinitdata = 1;
>> #else
>> +#ifndef MODULE
>> static int backlight __devinitdata = 0;
>> #endif
>> +#endif
>>
>> /* PLL constants */
>> struct aty128_constants {
>>
>
> [Added CC:Brad]
>
> Reviewed-by: Richard Genoud <richard.genoud@xxxxxxxxx>
>
sorry, there's still an error in the path (I reviewed a little bit to fast...).
the compilation breaks if "ATI Rage128 display support" is compile as
a module and "Support for backlight control (FB_ATY128_BACKLIGHT)" is
set
(cf line 1997)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
