I changed the patch to not define backlight only in case the driver is compiled as module. Now it compiles both statically or as module without errors or warnings. Patch is against 2.6.28.1 Signed-off-by: Daniele Venzano <venza@xxxxxxxxxxxx> --- linux-2.6.28.1/drivers/video/aty/aty128fb.c.old 2009-01-20 16:08:06.000000000 +0100 +++ linux-2.6.28.1/drivers/video/aty/aty128fb.c 2009-01-23 11:34:16.000000000 +0100 @@ -360,8 +360,10 @@ static int mtrr = 1; #ifdef CONFIG_PMAC_BACKLIGHT static int backlight __devinitdata = 1; #else +#ifndef MODULE static int backlight __devinitdata = 0; #endif +#endif /* PLL constants */ struct aty128_constants { -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html