Re: [PATCH] dsp56k: use request_firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-07-06 at 21:08 +0530, Jaswinder Singh wrote:
> Hello Fredrik,
> 
> On Sun, 2008-07-06 at 17:36 +0200, Fredrik Noring wrote:
> > Hi Jaswinder,
> > 
> > 6 jul 2008 kl. 17.13 skrev Jaswinder Singh:
> > > Updated patch :
> > > http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4


+Licence: GPL
+Assembly Source Code of ~50 lines can be generated by disassemble

Shouldn't that be 'GPLv2'? 

And it's better just to say '...but original assembler source code lost'
than to point say that it can be disassembled.

It would be better still to dig out a DSP56001 disassembler and actually
disassemble it. Why don't you do that?

> > > Thanks for you comments.
> > 
> > Excellent. (Unfortunately I don't have access to the hardware to test  
> > these changes.)
> 
> Please test this and let us know the result.

He said he can't.

> Please upload assembly code with Licence on Net so that I can point
> Assembly Source code in firmware/WHENCE.

I don't think he has it. That's why he suggested a disassembler.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux