Hello Fredrik,
On Sun, 2008-07-06 at 15:36 +0200, Fredrik Noring wrote:
> Hi Jaswinder,
>
> 5 jul 2008 kl. 12.24 skrev Jaswinder Singh:
> > + for (i = 0; i < fw->size; i + 3) {
>
> Are you sure about "i + 3" in this loop? Isn't GCC complaining,
> something like "statement with no effect"?
>
Fixed, Thanks.
> > +Driver: ATARI_DSP56K - Atari DSP56k support
> > +
> > +File: dsp56k/bootstap.bin
> > +
> > +Licence: Unknown
> > +
> > +Found in hex form in kernel source.
>
> I wrote this DSP56k assembler code in 1995. It's a trivial copy loop
> that loads the main DSP program into memory. Please consider it GPL
> like the driver code it came from.
>
> A disassembler would easily recreate the original ~50 lines of
> assembler source code, in case you'd like to assemble it with the rest
> of kernel. :)
>
Fixed.
Updated patch :
http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4
Thanks for you comments.
Thank you,
Jaswinder Singh.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
