On Thu, Feb 28, 2008 at 09:55:03PM -0800, Andrew Morton wrote: > if (invert) /* invert target value */ > - led_out = !led_out & 0x1; > + led_out = !led_out; > > if (!write_acpi_int(hotk->handle, ledname, led_out, NULL)) But now you're writing 0xffffffff instead of 1. I think the suggestion of led_out ^= 1 was the correct one. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html