Karol Kozimor wrote: > On 26-02-2008, at 21:42, Julia Lawall wrote: >> if (invert) /* invert target value */ >> - led_out = !led_out & 0x1; >> + led_out = !(led_out & 0x1); >> >> if (!write_acpi_int(hotk->handle, ledname, led_out, NULL)) >> printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n", > > > IIRC we're just supposed to flip the last bit here, so the original code > is correct. > Best regards, > Seems an odd way of doing: led_out ^= 0x01; It this due to some optimisation? Cheers, Mark. - To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
