Re: [PATCH] Some grammatical and whitespace cleanups in init.h.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 Nov 2007, Matthew Wilcox wrote:

> On Fri, Nov 30, 2007 at 04:01:56PM -0500, Robert P. J. Day wrote:
> > On Fri, 30 Nov 2007, Matthew Wilcox wrote:
> >
> > > On Fri, Nov 30, 2007 at 02:24:57PM -0500, Robert P. J. Day wrote:
> > > > -/* These macros are used to mark some functions or
> > > > - * initialized data (doesn't apply to uninitialized data)
> > > > - * as `initialization' functions. The kernel can take this
> > > > - * as hint that the function is used only during the initialization
> > > > - * phase and free up used memory resources after
> > > > +/* These macros are used to mark functions and initialized
> > > > + * data as 'initialization' objects, which tells the kernel that
> > > > + * they are used only during the initialization phase and can be
> > > > + * freed afterwards to recover memory.
> > >
> > > If you're going to get rid of 'some', then you need to change 'are' to
> > > 'may be' or 'can be'.
> >
> > i'm sorry, i don't see a problem here.  that replacement text looks
> > perfectly unambiguous.  how do you think it might be misinterpreted?
>
> It implies that all functions have to be marked as __init, which is
> plainly not true.

what nonsense.  the word "some" is entirely superfluous there.  are
you saying you would be confused if i said something like, "these red
tags are used to identify merchandise in the store that is on sale at
50% off."  are you seriously saying that, without the word "some", you
would think i was talking about every single piece of merchandise?

rday

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux