On Wed, Nov 13, 2024 at 2:35 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > On Wed, Nov 13, 2024 at 09:04:51AM -0500, Neal Gompa wrote: > > On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: > > > > > > > > Suggested-by: Petr Pavlu <petr.pavlu@xxxxxxxx> > > > > Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx> > > > > Acked-by: Neal Gompa <neal@xxxxxxxxx> > > > > > > Does this Ack add any value? > > > > > > Acked-by is meaningful only when it is given by someone who > > > maintains the relevant area or has established a reputation. > > > > > > $ git grep "Neal Gompa" > > > $ git shortlog -n -s | grep "Neal Gompa" > > > 2 Neal Gompa > > > > > > His Ack feels more like "I like it" rather than a qualified endorsement. > > > > > > > I have tested and looked over the patches from that lens. > > The tests you did, what exaclty was tested? > > If it was to just ensure no regressions, then that information is > useful too, and with that you can just provide: Tested-by. > > But actual details of what you test are useful. We now also have > automation of tests for modules, and expanding test coverage on that is > always welcomed too [0] [1] [2], so far we have 0 Rust coverage. > I tested that I could turn on MODVERSIONS with the relevant patch series, and get symbol expressions out of it. I didn't go very far into it, because I didn't want to invest in reworking the kernel symbol dependency generator for RPM packaged kernels to leverage this until after it is finally merged. But it worked as described, even if none of our kernel packaging infrastructure is adapted for it yet. To be honest, I considered sending both Acked-by and Tested-by, but I figured Acked-by would be sufficient given that I have also looked over the code as well and thought it was reasonable. Strictly speaking, we don't really use MODVERSIONS in Fedora, it's a CentOS/RHEL thing. But, pushing this forward helps make Rust enablement for Fedora easier because the Fedora kernel is managed through the ARK project, which is mostly oriented around the needs of the RHEL kernel team. And CentOS Hyperscale (which I am also part of and maintain a kernel for) does have MODVERSIONS on and I would like to be able to start enabling Rust stuff there (particularly Asahi code, as that's currently the main interesting thing in Rust to use). -- 真実はいつも一つ！/ Always, there's only one truth!
