On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: > > > > Suggested-by: Petr Pavlu <petr.pavlu@xxxxxxxx> > > Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx> > > Acked-by: Neal Gompa <neal@xxxxxxxxx> > > Does this Ack add any value? > > Acked-by is meaningful only when it is given by someone who > maintains the relevant area or has established a reputation. > > $ git grep "Neal Gompa" > $ git shortlog -n -s | grep "Neal Gompa" > 2 Neal Gompa > > His Ack feels more like "I like it" rather than a qualified endorsement. > I am going to be one of the primary consumers of this code as the Fedora Asahi kernel maintainer and have been driving Rust enablement in the Fedora Linux kernel (and eventually the RHEL kernel). I have tested and looked over the patches from that lens. While I might not be well-known here, I am known by the Rust for Linux folks, as well as the filesystem folks (since those are the main places I tend to frequent). I am also a member of the Asahi Linux team. I've been engaging with the Linux kernel community directly in some fashion for nearly a decade. Unfortunately, most of that isn't in the form of commits directly to the Linux kernel, though. -- 真実はいつも一つ！/ Always, there's only one truth!
