On Thu, Nov 07, 2024 at 04:59:14AM +0000, Koakuma wrote: > Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > > > Clang builds now succeed with this series and builds with GCC 14.2.0 > > continue to pass and boot successfully. > > > > Reviewed-by: Nathan Chancellor nathan@xxxxxxxxxx > > > > Tested-by: Nathan Chancellor nathan@xxxxxxxxxx > > > > One comment below, please carry these tags forward if there are future > > revisions without substantial technical changes. > > Forgive me for still being unfamiliar with the term, but does this mean that No worries, it is definitely a customary thing. > when I send a v4 I should paste the Reviewed-by and Tested-by lines into the > commit message of the patch? Yes, you should add them either right above or right below your signoff. It is up to the submitter to add tags that have been sent on prior revisions when sending an updated version, assuming that there has not been a reason to drop them, such as substantial changes from a prior version that might require a new review or testing. In that case, I typically add a note in the changelog as to why I did not carry them forward. The tip documentation 4.2.3 through 4.2.6 has some good information about some other Linux kernel commit message expectations if you find yourself submitting more patches in the future: https://docs.kernel.org/process/maintainer-tip.html#changelog > > > -KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu -fcall-used-g5 -fcall-used-g7 > > > +KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu $(call cc-option,-fcall-used-g5) $(call cc-option,-fcall-used-g7) > > > > > > Small nit, this (and the one in the vdso) could probably be one > > cc-option call? Is it likely that one flag would be implemented in the > > compiler without the other? > > > > $(call cc-option,-fcall-used-g5 -fcall-used-g7) > > Ah, didn't know it's possible to do that, the other uses of it I see seem > to use one flag per call. I'll test and send a new revision, thanks. Yeah, I would agree that it is typical to use cc-option for one flag at a time but the entire string just gets passed to $(CC), so there is technically no limitation for how many flags can be tested. This happens to be a rare instance where the flags share a common internal compiler implementation so we know that one cannot be implemented without the other. Cheers, Nathan
