Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > Clang builds now succeed with this series and builds with GCC 14.2.0 > continue to pass and boot successfully. > > Reviewed-by: Nathan Chancellor nathan@xxxxxxxxxx > > Tested-by: Nathan Chancellor nathan@xxxxxxxxxx > > One comment below, please carry these tags forward if there are future > revisions without substantial technical changes. Forgive me for still being unfamiliar with the term, but does this mean that when I send a v4 I should paste the Reviewed-by and Tested-by lines into the commit message of the patch? > > -KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu -fcall-used-g5 -fcall-used-g7 > > +KBUILD_CFLAGS += -m32 -mcpu=v8 -pipe -mno-fpu $(call cc-option,-fcall-used-g5) $(call cc-option,-fcall-used-g7) > > > Small nit, this (and the one in the vdso) could probably be one > cc-option call? Is it likely that one flag would be implemented in the > compiler without the other? > > $(call cc-option,-fcall-used-g5 -fcall-used-g7) Ah, didn't know it's possible to do that, the other uses of it I see seem to use one flag per call. I'll test and send a new revision, thanks.
