On Sat, Sep 28, 2024 at 3:53 AM Thomas Meyer <thomas@xxxxxxxx> wrote: > > > > Am 26. September 2024 17:33:20 MESZ schrieb Masahiro Yamada <masahiroy@xxxxxxxxxx>: > >On Wed, Sep 25, 2024 at 5:50 AM Miguel Ojeda > ><miguel.ojeda.sandonis@xxxxxxxxx> wrote: > >> > >> On Tue, Sep 24, 2024 at 9:26 PM Thomas Meyer <thomas@xxxxxxxx> wrote: > >> > > >> > Make build succeed on systems whose c library doesn't provided the deprecated bcmp function. > >> > >> It would be good to mention which systems are those. Other than that, > >> it looks good to me: > >> > >> Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx> > >> > >> Cheers, > >> Miguel > > > > > >Agree. > > > >If there is a known system that does not provide bcmp, > >that information is appreciated. > > This fix is needed when I try to build Linux kernel on my Android phone under Termux with bionic libc, which only seems to implement memcmp. OK, thanks. Please add a little more description in v2. For example, bcmp() was removed in POSIX.1-2008. This commit replaces bcmp() with memcmp(). This allows Kconfig to link with C libraries that do not provide bcmp(), such as Android bionic libc. > > > >It might be useful to add a link that mentions that this function is LEGACY. > > > >https://pubs.opengroup.org/onlinepubs/007904875/functions/bcmp.html > > > > > > -- > Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet. > -- Best Regards Masahiro Yamada
