On Tue, Sep 17, 2024 at 4:17 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > Since commit 2f7ab1267dc9 ("Kbuild: add Rust support"), Kconfig > generates include/generated/rustc_cfg, but its presence is not checked > in the top-level Makefile. It should be checked similarly to the C > header counterpart, include/generated/autoconf.h. > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> Sounds good to me: Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx> I also tested that it indeed prints it if removed: *** *** ERROR: Kernel configuration is invalid. The following files are missing: *** - ....../linux/include/generated/rustc_cfg *** Run "make oldconfig && make prepare" on kernel source to fix it. *** which is nice! So: Tested-by: Miguel Ojeda <ojeda@xxxxxxxxxx> I guess this tag may apply to the previous patch too. Cheers, Miguel