On Fri, Aug 16, 2024 at 11:20 AM TIAN Yuanhao <tianyuanhao3@xxxxxxx> wrote: > > At 2024-08-16 09:52:57, "Masahiro Yamada" <masahiroy@xxxxxxxxxx> wrote: > >On Fri, Aug 16, 2024 at 7:41 AM Rob Herring <robh@xxxxxxxxxx> wrote: > >> > >> +Masahiro > >> > >> (use get_maintainers.pl in the future) > >> > >> On Thu, Aug 15, 2024 at 5:01 AM TIAN Yuanhao <tianyuanhao3@xxxxxxx> wrote: > >> > > >> > At present Linux always builds dtc if CONFIG_DTC is defined, even when > >> > DTC is provided. The built dtc is not actually used, so this is a waste > >> > of time. > >> > >> That's kind of a edge usecase, so I'm not sure it is worth the > >> complexity. > > > > > >Indeed. Not worth the complexity. > > > > > >Overriding DTC is not a general use. > >It is a knob so that someone can test the latest > >dtc from upstream. > > > Some meta distributions such as Yocto and Buildroot compile a common host dtc, while ATF, U-Boot, and Linux can share the same host dtc. If distro's dtc works for the kernel, we should remove scripts/dtc/. Instead, we need to start caring about the minimal supported dtc version. And, it will make it difficult to add a new warning flag. We can use external dtc only when it is the same version or newer than the internal one. If you use an older external dtc, some of the dtc warning options may not be supported. > >> We could also just make CONFIG_DTC visible so it can be > >> disabled. Or make it a path defaulting to the built-in one. Maybe > >> Masahiro has some ideas. > > > > > >Let's not do anything. > > > > > >This patch is NACK. > > > > > If you think there is still room for discussion on this topic, I can split this patch into two as Rob suggested. No, splitting the patch does not help anything. > > > > > > > >> > >> > Update the Makefile logic to build dtc and fdtoverlay only if DTC or > >> > FDTOVERLAY is not provided. > >> > >> Overriding fdtoverlay is not even supported currently. Adding support > >> for that should be a separate patch. > >> > >> > Also, add an fdtoverlay wrapper to hide the actual path differences of > >> > fdtoverlay from the make_fit.py script. > >> > >> That's ugly. > >> > >> Rob > > > > > > > >-- > >Best Regards > > > >Masahiro Yamada > -- > Best Regards > TIAN Yuanhao > -- Best Regards Masahiro Yamada
