Re: [PATCH 1/1] kbuild: Only build dtc if needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 16, 2024 at 7:41 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> +Masahiro
>
> (use get_maintainers.pl in the future)
>
> On Thu, Aug 15, 2024 at 5:01 AM TIAN Yuanhao <tianyuanhao3@xxxxxxx> wrote:
> >
> > At present Linux always builds dtc if CONFIG_DTC is defined, even when
> > DTC is provided. The built dtc is not actually used, so this is a waste
> > of time.
>
> That's kind of a edge usecase, so I'm not sure it is worth the
> complexity.


Indeed. Not worth the complexity.


Overriding DTC is not a general use.
It is a knob so that someone can test the latest
dtc from upstream.


> We could also just make CONFIG_DTC visible so it can be
> disabled. Or make it a path defaulting to the built-in one. Maybe
> Masahiro has some ideas.


Let's not do anything.


This patch is NACK.





>
> > Update the Makefile logic to build dtc and fdtoverlay only if DTC or
> > FDTOVERLAY is not provided.
>
> Overriding fdtoverlay is not even supported currently. Adding support
> for that should be a separate patch.
>
> > Also, add an fdtoverlay wrapper to hide the actual path differences of
> > fdtoverlay from the make_fit.py script.
>
> That's ugly.
>
> Rob



--
Best Regards

Masahiro Yamada





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux