On Wed, Jun 5, 2024 at 12:49 PM Richard Acayan <mailingradian@xxxxxxxxx> wrote:
>
> In commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed
> script"), the mksysmap script was transformed into a sed script,
> made directly executable with "#!/bin/sed -f". Apparently, the path to
> sed is different on NixOS, fixed by using the env command.
>
> To accommodate the number of arguments above the normal maximum for
> hashbangs, the -S flag of env was used (as in
> "#!/usr/bin/env -S sed -f"). However, env -S is a GNU extension.
> Explicitly use sed instead of relying on the executable shebang to keep
> compatibility with build environments using Busybox.
I am fine with the code.
Kent will drop his local commit, so please reword the commit description
without 973eca8db557 in mind.
> Fixes: 973eca8db557 ("kbuild: mksysmap now works on nixos")
Please replace this tag with:
Fixes: b18b047002b7 ("kbuild: change scripts/mksysmap into sed script")
Thanks.
> Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
> ---
> scripts/link-vmlinux.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 46ce5d04dbeb..518c70b8db50 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -193,7 +193,7 @@ kallsyms_step()
> mksysmap()
> {
> info NM ${2}
> - ${NM} -n "${1}" | "${srctree}/scripts/mksysmap" > "${2}"
> + ${NM} -n "${1}" | sed -f "${srctree}/scripts/mksysmap" > "${2}"
> }
>
> sorttable()
> --
> 2.45.2
>
--
Best Regards
Masahiro Yamada
