Re: [PATCH -next] kbuild: explicitly run mksysmap as sed script from link-vmlinux.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 5, 2024 at 12:49 PM Richard Acayan <mailingradian@xxxxxxxxx> wrote:
>
> In commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed
> script"), the mksysmap script was transformed into a sed script,
> made directly executable with "#!/bin/sed -f". Apparently, the path to
> sed is different on NixOS, fixed by using the env command.
>
> To accommodate the number of arguments above the normal maximum for
> hashbangs, the -S flag of env was used (as in
> "#!/usr/bin/env -S sed -f"). However, env -S is a GNU extension.
> Explicitly use sed instead of relying on the executable shebang to keep
> compatibility with build environments using Busybox.
>
> Fixes: 973eca8db557 ("kbuild: mksysmap now works on nixos")


There is no 973eca8db557 in my tree.

I do not even see it in ML.

Where did it come from, and where will it go?




commit 973eca8db5570dd0c3f2b3190867138cc446eb3b
Author:     Kent Overstreet <kent.overstreet@xxxxxxxxx>
AuthorDate: Sun Jun 2 23:13:35 2024 -0400
Commit:     Kent Overstreet <kent.overstreet@xxxxxxxxx>
CommitDate: Sun Jun 2 23:23:47 2024 -0400

    kbuild: mksysmap now works on nixos

    Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>

diff --git a/scripts/mksysmap b/scripts/mksysmap
index c12723a04655..835cccf8e7de 100755
--- a/scripts/mksysmap
+++ b/scripts/mksysmap
@@ -1,4 +1,4 @@
-#!/bin/sed -f
+#!/usr/bin/env -S sed -f
 # SPDX-License-Identifier: GPL-2.0-only
 #
 # sed script to filter out symbols that are not needed for System.map,









-- 
Best Regards
Masahiro Yamada





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux