Hi, On 2/27/24 22:00, Tomasz Figa wrote: > When hidden options are toggled on (using 'z'), the number of options > on the screen can be overwhelming and may make it hard to distinguish > between available and hidden ones. Make them easier to distinguish by > displaying the hidden one with a different color (COLOR_YELLOW for color > themes and A_DIM for mono). > Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> > --- > scripts/kconfig/lxdialog/dialog.h | 5 +++++ > scripts/kconfig/lxdialog/menubox.c | 12 ++++++++---- > scripts/kconfig/lxdialog/util.c | 19 +++++++++++++++++++ > scripts/kconfig/mconf.c | 18 ++++++++++++++++++ > 4 files changed, 50 insertions(+), 4 deletions(-) > Changes from v1: > (https://patchwork.kernel.org/project/linux-kbuild/patch/20231228054630.3595093-1-tfiga@xxxxxxxxxxxx/) > * Replaced A_DIM for color themes with COLOR_YELLOW, because the former > has no effect to black text on some commonly used terminals, e.g. > gnome-terminal, foot. Reported by Masahiro Yamada and Nicolas Schier. > I ended up with COLOR_YELLOW, as it seems to look comparatively dim > with mutliple light and dark color themes in Chromium hterm and > gnome-terminal. I guess COLOR_YELLOW is a relative thing, i.e., it depends on the term's current color scheme in my testing. With rxvt (with a beige/khaki background), I do see yellow. With xfce4-terminal (with amber/orange foreground on black background, i.e., my default from days of amber monochrome displays ;), the "yellow" comes out as a faded/washed out/dim orange. But still readable. Anyway, this looks useful to me. Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> thanks. -- #Randy
