Re: [PATCH v2] kconfig: menuconfig: Make hidden options show with different color

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 28, 2024 at 3:00 PM Tomasz Figa <tfiga@xxxxxxxxxxxx> wrote:
>
> When hidden options are toggled on (using 'z'), the number of options
> on the screen can be overwhelming and may make it hard to distinguish
> between available and hidden ones. Make them easier to distinguish by
> displaying the hidden one with a different color (COLOR_YELLOW for color
> themes and A_DIM for mono).
>
> Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
> ---


> diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
> index 3f78fb265136..161224dd6fb5 100644
> --- a/scripts/kconfig/lxdialog/util.c
> +++ b/scripts/kconfig/lxdialog/util.c
> @@ -38,6 +38,8 @@ static void set_mono_theme(void)
>         dlg.menubox_border.atr = A_NORMAL;
>         dlg.item.atr = A_NORMAL;
>         dlg.item_selected.atr = A_REVERSE;
> +       dlg.item_hidden.atr = A_NORMAL | A_DIM;


Nit.


(A_NORMAL | A_DIM) should be A_DIM.


A_NORMAL is zero.

Other A_* attributes are bit flags that can be OR'ed.




--
Best Regards
Masahiro Yamada





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux