On Fri, Aug 11, 2023 at 08:23:45PM +0200, Arnd Bergmann wrote: > On Fri, Aug 11, 2023, at 18:09, Nathan Chancellor wrote: > > On Fri, Aug 11, 2023 at 04:03:27PM +0200, Arnd Bergmann wrote: > >> From: Arnd Bergmann <arnd@xxxxxxxx> > >> > >> A number of warning options from the W=1 set are completely clean in current > >> kernels, so we should just enable them by default, including a lot of warnings > >> that are part of -Wextra, so just turn on -Wextra by default. > >> > >> The -Woverride-init, -Wvoid-pointer-to-enum-cast and > >> -Wmissing-format-attribute warnings are part of -Wextra but still produce > >> some legitimate warnings that need to be fixed, so leave them at the > >> W=1 level but turn them off otherwise. > >> > >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > ... > >> -KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare > >> -KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access) > >> -KBUILD_CFLAGS += $(call cc-disable-warning, cast-function-type-strict) > > > > I am still running through my builds but I don't think that dropping > > these three is acceptable at the moment. I see a good number of all of > > these warnings in -next still. I see some patches that I have picked up > > to address a couple of the really noisy ones but some others that I > > looked at are not fixed. I'll have a list eventually. > > Ok, thanks. I have a backlog of warning fixes in my randconfig > tree, which is currently clean with these warnings addressed, at > least on arm/arm64/x86 and it looks like there are a couple that > I've never sent out so far. I'll drop the above for now, as I > won't have time to send all the fixes before my vacation. Thanks, that takes care of the vast majority of extra warnings that this series produces. I have included all my build logs at [1]. The slightly-filtered-warnings file is the result of searching for all warnings in the log files and passing them through 'sort | uniq -c', additionally ignoring the instances of -Wnull-pointer-arithmetic that are present in certain configurations, as those are pretty well known at this point. The more-filtered-warnings file does the same thing but also ignores instances of the three warnings above, which just reveals some instances of -Wunused-but-set-parameter, which I am pretty sure I have seen you sent fixes for recently, so I think with those three warnings left as disabled, this series should be safe. [1]: https://github.com/nathanchance/bug-files/tree/9100c6a21cbdce3c03fbca1bd00a7c34f316a137/enable-more-W%3D1-warnings-by-default Cheers, Nathan
