Re: [PATCH 9/9] [RFC] extrawarn: enable more W=1 warnings by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 11, 2023, at 18:09, Nathan Chancellor wrote:
> On Fri, Aug 11, 2023 at 04:03:27PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> A number of warning options from the W=1 set are completely clean in current
>> kernels, so we should just enable them by default, including a lot of warnings
>> that are part of -Wextra, so just turn on -Wextra by default.
>> 
>> The -Woverride-init, -Wvoid-pointer-to-enum-cast and
>> -Wmissing-format-attribute warnings are part of -Wextra but still produce
>> some legitimate warnings that need to be fixed, so leave them at the
>> W=1 level but turn them off otherwise.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ...
>> -KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
>> -KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
>> -KBUILD_CFLAGS += $(call cc-disable-warning, cast-function-type-strict)
>
> I am still running through my builds but I don't think that dropping
> these three is acceptable at the moment. I see a good number of all of
> these warnings in -next still. I see some patches that I have picked up
> to address a couple of the really noisy ones but some others that I
> looked at are not fixed. I'll have a list eventually.

Ok, thanks. I have a backlog of warning fixes in my randconfig
tree, which is currently clean with these warnings addressed, at
least on arm/arm64/x86 and it looks like there are a couple that
I've never sent out so far. I'll drop the above for now, as I
won't have time to send all the fixes before my vacation.

I can provide the ones I have off-list for reference, but there
are a couple that are missing changelog texts or that I'm not
entirely sure about myself.

    Arnd



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux