On Sun, Aug 6, 2023 at 11:30 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > Hi Jesse, > > On 8/5/23 20:20, Jesse Taube wrote: > > In this Menuconfig, pressing the key in the (#) prefix will jump > > directly to that location. You will be returned to the current search > > results after exiting this new menu. > > > > In nconfig, exiting always returns to the top of the search output, not > > to where the (#) was displayed on the search output screen. > > > > This patch fixes that by saving the current position in the search. > > > > This patch fixes the reported problem. Thanks, Jesse. > > > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/20230805034445.2508362-1-Mr.Bossman075@xxxxxxxxx/ > > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx> > > Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Now I have another issue. :( > > Here is my test case: x86_64 defconfig. > > SymSearch (F8) for MSR. > Page Down to #3. Select 3. > X86_MSR is about 7 lines below the highlighted line in the menu, > which is confusing and sometimes it's not obvious what the correct > line for the symbol is. > > In menuconfig, the highlighted line is precisely on X86_MSR. Oh jeez, how did I miss this? I will fix this asap as this seems to be a big issue as it can easily cause confusion. Weirdly all the test cases I used were fine, but I found a few more like this. Thanks, Jesse Taube > > Can nconfig be more precise about which menu line it highlights? > > Thanks for your help. > > > --- > > scripts/kconfig/nconf.c | 3 ++- > > scripts/kconfig/nconf.gui.c | 12 +++++++++++- > > scripts/kconfig/nconf.h | 1 + > > 3 files changed, 14 insertions(+), 2 deletions(-) > > > -- > ~Randy
