Re: [PATCH v1] kconfig: nconf: Keep position after jump search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jesse,

On 8/5/23 20:20, Jesse Taube wrote:
> In this Menuconfig, pressing the key in the (#) prefix will jump
> directly to that location. You will be returned to the current search
> results after exiting this new menu.
> 
> In nconfig, exiting always returns to the top of the search output, not
> to where the (#) was displayed on the search output screen.
> 
> This patch fixes that by saving the current position in the search.
> 

This patch fixes the reported problem. Thanks, Jesse.

> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20230805034445.2508362-1-Mr.Bossman075@xxxxxxxxx/
> Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>

Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Now I have another issue. :(

Here is my test case: x86_64 defconfig.

SymSearch (F8) for MSR.
Page Down to #3. Select 3.
X86_MSR is about 7 lines below the highlighted line in the menu,
which is confusing and sometimes it's not obvious what the correct
line for the symbol is.

In menuconfig, the highlighted line is precisely on X86_MSR.

Can nconfig be more precise about which menu line it highlights?

Thanks for your help.

> ---
>  scripts/kconfig/nconf.c     |  3 ++-
>  scripts/kconfig/nconf.gui.c | 12 +++++++++++-
>  scripts/kconfig/nconf.h     |  1 +
>  3 files changed, 14 insertions(+), 2 deletions(-)


-- 
~Randy



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux