On 16.06.2023 08:37, Kent Overstreet wrote: > On Thu, Jun 15, 2023 at 11:54:23AM +0200, Peter Oberparleiter wrote: >> I'll likely not be able to implement this myself, but if you or anyone >> else wants to go that route, here are my thoughts: $(src) should have >> the relative source code path that is needed, so here's what needs to be >> done: >> >> 1. Determine how to handle non-letter/digit/underscore characters in the >> variable name: >> >> a) GCOV_PROFILE_fs/bcachefs => supported by GNU make [1], though >> discouraged due to possible side-effects >> b) GCOV_PROFILE_fs_bcachefs => might cause overlays, e.g. a/b/c and >> a/b_c both have the same a_b_c suffix >> >> Personally I'd prefer option b) > > Agreed, feels more consistent > >> 2. Define a new Makefile variable that contains $(src) with required >> character replacements (scripts/Kbuild.include might be a good place) >> >> 3. Add $(GCOV_PROFILE_$(name_of_that_new_var)) to the code quoted above >> (scripts/Makefile.lib) > > So this is where I was getting stuck, because we really want this to > apply to subdirectories (e.g. GCOV_PROFILE_fs_xfs should really also > apply to fs/xfs/libxfs). > > Do we have existing code for generating a list of path prefixes for a > given path? Not that I know of. Here's how it could be made to work using Makefile magic alone (as a pure programming exercise :) This will expand a directory to a list of all parent directories: # expand_parents(a/b/c) = a/b/c a/b a expand_parents2 = $(if $(subst .,,$(1)),$(call expand_parents,$(1)),) expand_parents = $(1) $(call expand_parents2,$(patsubst %/,%,$(dir $(1)))) This list could then be turned into variable suffixes: # flatten_dirs(a/b/c) = a_b_c a_b a flatten_dirs = $(subst /,_,$(call expand_parents,$(1))) And finally the resulting list of suffixed variables could be evaluated: # eval_vars(X_,a/b/c) = $(X_a_b_c) $(X_a_b) $(X_a) eval_vars = $(foreach var,$(call flatten_dirs,$(2)),$($(1)$(var))) So a call like this $(call eval_vars,GCOV_PROFILE_,a/b/c) would evaluate to the concatenation of the contents of the following variables: GCOV_PROFILE_a_b_c GCOV_PROFILE_a_b GCOV_PROFILE_a The first non-empty variable would then determine whether profiling should be enabled for the associated source file or not. This would even implement the correct order of precedence (specific to generic) Not sure if this amount of magic is suitable for kbuild though. An alternative, less complex approach would be to move this decision logic to a helper script. -- Peter Oberparleiter Linux on IBM Z Development - IBM Germany R&D
