On Tue, May 23, 2023 at 1:59 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Sat, May 20, 2023 at 6:28 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Thu, May 18, 2023 at 6:14 AM Nick Desaulniers > > <ndesaulniers@xxxxxxxxxx> wrote: > > > > > > On Sun, May 14, 2023 at 8:28 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > > > find_elf_symbol() and find_elf_symbol2() are not good names. > > > > > > > > Rename them to find_tosym(), find_fromsym(), respectively. > > > > > > The comments maybe could be updated, too. The end of the comment looks > > > wrong for both. > > > > > > What do you mean? > > > > Please tell me which part should be changed, and how. > > Attached the comment style changes. I didn't have precise wording in > mind for the comments; I was suggesting to see if the comments could > be updated to clarify what the functions are doing. Ah, I understood what you meant. I think some parts of the comments are stale. Anyway, these comment blocks will be removed by a later commit. https://patchwork.kernel.org/project/linux-kbuild/patch/20230521160426.1881124-6-masahiroy@xxxxxxxxxx/ -- Best Regards Masahiro Yamada
