On Sat, Apr 8, 2023 at 4:01 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Fri, Apr 7, 2023 at 11:59 AM Nick Desaulniers > <ndesaulniers@xxxxxxxxxx> wrote: > > > > On Wed, Mar 8, 2023 at 3:53 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > Move comments close to the code. > > > > Consider adding to the commit message why you switch from grep to sed; > > that's currently unclear. > > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > Also, perhaps scripts/mksysmap could just be replaced with a sed > input-file? Then > scripts/link-vmlinux.sh would invoke nm and pipe it into that sed script? I still need shell. The last line of the next commit 4/8 uses shell code. -- Best Regards Masahiro Yamada
