On Sat, Apr 8, 2023 at 4:00 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Wed, Mar 8, 2023 at 3:53 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > Move comments close to the code. > > Consider adding to the commit message why you switch from grep to sed; > that's currently unclear. I just thought "Move comments close to the code" explained my motivation., I want to insert in-line comments. Something like the following. Apparently, it does not work. $NM -n $1 | grep -v \ # comment1 -e ' [aNUw] ' \ # comment2 -e ' \$' \ # comment3 -e ' \.L' \ # comment4 -e ' __crc_' \ # comment5 -e ' __kstrtab_' \ # comment6 -e ' __kstrtabns_' \ # comment7 -e ' L0$' \ > $2 > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > Orthogonal to this patch, don't .L prefixed local symbols not have > entries in the symbol table? If they're not printed with nm, why > filter them out (since they're impossible). Sorry, I could not understand your question, but you may get something from d4c858643263cfde13f7d937eaff95c2ed87cdf1 (you reviewed it) -- Best Regards Masahiro Yamada