On Wed, Jan 12, 2022 at 3:50 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > Sure, but none of this is relevant for the short term fix that we need > to get in asap. There are lots of future changes we can philosophize > about, but those discussions should take place on the linux-crypto > list after the merge window closes. I think of adding things to the root menu as a regression. I'd like to avoid an additional regression in fixing this. > > > and given that this > > > patch is presumably going to be sent as an early fix on top of your > > > rng branch, it is better not to touch anything under crypto/ unless > > > you are 100% certain it is not going to conflict with Herbert's tree. > > > > Oh, I was thinking Herbert would take this since he hasn't sent a pull > > yet? Otherwise, sure, I can do it. > > > > How could he? This patch does not apply to his cryptodev tree, which > won't receive backmerges from mainline until the next cycle. Oh, okay then. I'll take it. In which case, I really don't want to be the one responsible for mucking up the root menu with something nobody cares about (crypto library submenu). I'll fix up the menu location thing locally then and send a v3 here. Jason
