On Wed, Jan 12, 2022 at 3:42 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > On Wed, 12 Jan 2022 at 15:15, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > On Wed, Jan 12, 2022 at 3:13 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > > > > > On Wed, 12 Jan 2022 at 15:12, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > > > > > On Wed, Jan 12, 2022 at 3:08 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > > > > > > > > > On Wed, 12 Jan 2022 at 15:08, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > > > > > > > > > On Wed, Jan 12, 2022 at 3:06 PM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > > > > > > > > > > > > > On Wed, 12 Jan 2022 at 15:05, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > > > > > > > > > > > > > This commit also needs this snippet: > > > > > > > > > > > > > > > > > > > > > > Why? > > > > > > > > > > > > So that the menu of crypto library options is inside of the library > > > > > > menu. Otherwise this will appear inside of the _root_ menu, which > > > > > > isn't what we want. > > > > > > > > > > Why not? I think that's fine. > > > > > > > > It's really not appropriate there. Look: > > > > > > > > - Justin vanilla: https://i.imgur.com/14UBpML.png > > > > - Justin + Jason: https://i.imgur.com/lDfZnma.png > > > > > > > > We really don't want another top level menu. We're not that important. > > > > Rather, crypto libraries are but one ordinary subset of ordinary > > > > libraries, just like how the build system does it too. > > > > > > I disagree. The root menu is a jumble of things already, and having > > > this one at the root is really not a problem. > > > > Should CRC routines also go into a submenu and be put at the root? > > What about other library functions? Library functions belong in the > > library submenu. We don't need our own top level submenu for this. The > > whole point of lib/crypto/ is that they're just boring library > > functions. Libraries! So, part of the libraries menu. > > Shouting it doesn't make it true. I'm not shouting. I respectfully disagree with your perspective. I think the comparison to CRC routines is an apt one, still unaddressed. > Nobody cares about what the root menu looks like I certainly do. > and given that this > patch is presumably going to be sent as an early fix on top of your > rng branch, it is better not to touch anything under crypto/ unless > you are 100% certain it is not going to conflict with Herbert's tree. Oh, I was thinking Herbert would take this since he hasn't sent a pull yet? Otherwise, sure, I can do it. Jason
