On Sat, Dec 25, 2021 at 06:38:02AM +0530, Vimal Agrawal wrote: > On Fri, Dec 24, 2021 at 12:17 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > I don't think we can support passing arbitrary linker options and > > expects things to work. If we want to support --strip-unneeded > > it needs a good rationale and be added as a direct config option. > INSTALL_MOD_STRIP was provided to give flexibility for providing > strippping options. Yes but the point here is the heuristic you are adding for when "--strip-unneeded" is used is now *always* being used and we have no way of knowing this. So I'd agree with Christoph that if we want to support this it might make sense to make a kconfig option for enabling "--strip-unneeded" and then another for this heuristic. You may want to work on top of Aaron's patches as that would make adding new kconfig entries for modules much cleaner: https://lkml.kernel.org/r/20220106234319.2067842-1-atomlin@xxxxxxxxxx I hope to review those this week, so I might have a tree you can work off on by the end of this or next week. Luis
