On Thu, Dec 23, 2021 at 04:39:15PM +0530, Vimal Agrawal wrote: > Hi Christoph, > > On Thu, Dec 23, 2021 at 4:06 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > We never build modules with that ёption, so this is completely pointless. > > > we use openwrt for build and packaging and it has been using this > option for long. > > kbuild documentation says the following for INSTALL_MOD_STRIP: > If this variable is specified, it will cause modules to be stripped > after they are installed. If INSTALL_MOD_STRIP is ‘1’, then the > default option –strip-debug will be used. Otherwise, the > INSTALL_MOD_STRIP value will be used as the option(s) to the strip > command. > > So if kbuild does not support INSTALL_MOD_STRIP=--strip-unneeded > option then we should call out what it supports and should not even > allow what is not supported. We don't know what other options others > may be using but if we allow it then we should support it and it > should not behave erratic just because someone is using a > non-recommended option. I don't think we can support passing arbitrary linker options and expects things to work. If we want to support --strip-unneeded it needs a good rationale and be added as a direct config option.
