On Mon, Dec 6, 2021 at 8:14 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Dec 06, 2021 at 04:56:32PM +0100, Miguel Ojeda wrote: > > On Mon, Dec 6, 2021 at 4:46 PM Greg Kroah-Hartman > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > That should be in a .h file somewhere. Remember, don't put #ifdef in .c > > > files please. Why not put #ifdef in .c files? > > Will do, thanks for reviewing! > > > > > Same here, this should not be needed if you put it in a .h file > > > correctly. I guess IS_ENABLED could be used in the .c code, but I don't see how they could move the dispatch to rust_fmt_argument to a header without moving the definition of pointer() to a header, which they probably _cant_ do because it's noinline_for_stack. > > > > This one is mimicking the `CONFIG_BLOCK` one (`case 'g'` a bit above) > > -- but we can change it, of course. > > That should be changed as well :) Isn't the point to minimize code that's unused for certain configurations? -- Thanks, ~Nick Desaulniers
