On Mon, Dec 06, 2021 at 04:56:32PM +0100, Miguel Ojeda wrote: > On Mon, Dec 6, 2021 at 4:46 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > That should be in a .h file somewhere. Remember, don't put #ifdef in .c > > files please. > > Will do, thanks for reviewing! > > > Same here, this should not be needed if you put it in a .h file > > correctly. > > This one is mimicking the `CONFIG_BLOCK` one (`case 'g'` a bit above) > -- but we can change it, of course. That should be changed as well :)