On Wed, Apr 7, 2021 at 5:37 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Apr 07, 2021 at 09:14:36AM +0100, Russell King - ARM Linux admin wrote: > > On Wed, Apr 07, 2021 at 10:07:29AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Apr 07, 2021 at 09:02:29AM +0100, Russell King - ARM Linux admin wrote: > > > > On Wed, Apr 07, 2021 at 09:46:18AM +0200, Greg Kroah-Hartman wrote: > > > > > On Wed, Apr 07, 2021 at 09:18:11AM +0200, Geert Uytterhoeven wrote: > > > > > > Hi Greg, > > > > > > > > > > > > Thanks for your series! > > > > > > > > > > > > On Wed, Apr 7, 2021 at 7:34 AM Greg Kroah-Hartman > > > > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > Almost every architecture has copied the "install.sh" script that > > > > > > > originally came with i386, and modified it in very tiny ways. This > > > > > > > patch series unifies all of these scripts into one single script to > > > > > > > allow people to understand how to correctly install a kernel, and fixes > > > > > > > up some issues regarding trying to install a kernel to a path with > > > > > > > spaces in it. > > > > > > > > > > > > > > Note that not all architectures actually seem to have any type of way to > > > > > > > install a kernel, they must rely on external scripts or tools which > > > > > > > feels odd as everything should be included here in the main repository. > > > > > > > I'll work on trying to figure out the missing architecture issues > > > > > > > afterward. > > > > > > > > > > > > I'll bite ;-) > > > > > > > > > > > > Does anyone actually use these scripts (outside of x86)? > > > > > > > > Yes, every time I build a kernel. My kernel build system involves > > > > typing "kbuild <flags> <dirname> <machines...>" and the kernel gets > > > > built in ../build/<dirname>. When the build completes, it gets > > > > installed into ~/systems/<dirname>, tar'd up, and copied to the > > > > destination machines, unpacked, installed as appropriate, and > > > > the machine rebooted if requested. > > > > > > > > The installation step is done via the ~/bin/installkernel script. > > > > > > So you don't use install.sh at all except to invoke your local script. > > > > It depends where the kernel is being built; it has been used in the > > past (one will notice that the arm32 version is not a direct copy of > > the x86 version, and never was - it was modified from day 1.) It's > > placement and naming of the files in /boot is still used today, which > > is slightly different from the x86 version. > > The placement depends on the caller to the script, so that's not an > issue here. The name for the output does differ from x86, but the > "common" script handles all of that (or it should, if not I messed up.) > > Attached below is the common scripts/install.sh that this patch series > produces at the end of it, if you want to check to see if I missed > anything for your arch. > > thanks, > > greg k-h Thanks for nice cleanups! I will give some nit-picking comments to individual patches. Overall, this series looks nice. -- Best Regards Masahiro Yamada
