Hi Viresh, On 3/24/21 2:34 AM, Frank Rowand wrote: > On 3/16/21 12:42 AM, Viresh Kumar wrote: >> On 16-03-21, 00:36, Frank Rowand wrote: >>> I should have looked at patch 3/5 more carefully instead of counting on >>> Masahiro to check it out and simply build testing. >>> >>> Patch 3/5 does not seem correct. I'll look over all the makefile related >>> changes that have been accepted (if any) and patch 3/5 later today (Tuesday). >> >> What is already merged by Rob is what everyone reviewed and it wasn't >> related to this .dtso/.dtbo discussion we are having. I will resend a >> new patchset with the stuff left for merging (which will involve the >> thing we are discussing here), so we can get a clear picture of it. >> > > Instead of doing what I suggested in my 16-03-21, 00:36 email (only > partly quoted above), I have made most of the changes to unittest.c > and drivers/of/unitest/unittest-data/Makefile to allow the unittest > .dts files to be .dtso source files and .dtbo FDT files, and tested. > One final step remaining in my work is to actually rename the *.dts > files to *.dtso. > > I hope to finish this later today (Wednesday) after getting some > sleep. I have submitted a patch that I _think_ removes the need for most of patch 3/5, _other_ than the yaml rule, which I would assume is still needed, though I did not examine it. My patch is https://lore.kernel.org/r/20210324223713.1334666-1-frowand.list@xxxxxxxxx Can you do a new patch with just the yaml rule (if Rob accepts my patch). -Frank